Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure lsame_ is exported #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mmuetzel
Copy link

The reference (netlib) LAPACK implementation exports lsame_ unconditionally. When trying to use libflame as a drop-in replacement for the reference implementation on Windows, programs fail to start with an error that the symbol lsame_ is undefined. IIUC, that is because the symbol resolution is done on link time for Windows (instead of at runtime on most other platforms).

The proposed change makes sure that lsame_ is exported from libflame even if configured with --disable-lapack2flame --disable-builtin-blas (the default).

IIUC, an alternative would be to export this symbol defined in src/flablas/f2c/lsame.c. But the proposed change is a bit closer to the reference implementation.

See also this downstream report: https://savannah.gnu.org/bugs/index.php?63184

The reference (netlib) LAPACK implementation exports `lsame_` unconditionally.
When trying to use libflame as a drop-in replacement for the reference implementation on Windows, programs fail to start with an error that the symbol `lsame_` is undefined.
IIUC, that is because the symbol resolution is done on link time for Windows (instead of at runtime on most other platforms).

The proposed change makes sure that `lsame_` is exported from libflame even if configured with `--disable-lapack2flame --disable-builtin-blas` (the default).

IIUC, an alternative would be to export this symbol defined in `src/flablas/f2c/lsame.c`. But the proposed change is a bit closer to the reference implementation.

See also this downstream report: https://savannah.gnu.org/bugs/index.php?63184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant